fix(fe/dashboard-list): display modifier info for `Last modified` data by hainenber · Pull Request #32035 · apache/superset

hainenber · 2025-01-30T08:16:25Z

SUMMARY

fix(fe/dashboard-list): display modifier info for Last modified data

Fix #31258

The tooltip showing modifier data on Last modified cell is now restored.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

Screen.Recording.2025-01-30.at.21.10.59.mov

After

Screen.Recording.2025-01-30.at.21.08.55.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue: 31258
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

Signed-off-by: hainenber <dotronghai96@gmail.com>

korbit-ai · 2025-01-30T08:16:29Z

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

Signed-off-by: hainenber <dotronghai96@gmail.com>

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset-frontend/src/pages/DashboardList/index.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

Chat with Korbit on issues we post by tagging @korbit-ai in your reply.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Naming ✅

Database Operations ✅

Documentation ✅

Logging ✅

Error Handling ✅

Systems and Environment ✅

Objects and Data Structures ✅

Readability and Maintainability ✅

Asynchronous Processing ✅

Design Patterns ✅

Third-Party Libraries ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

sfirke · 2025-02-06T16:18:36Z

Thanks for this fix! Did you see that in the issue, I identified what I think is an end-to-end test that failed to catch this regression? If my assessment is correct - I'm new to that part of the project - it would be ideal if this test got updated to avoid such a regression in the future.

hainenber · 2025-02-11T15:09:21Z

@sfirke the linked test is not an E2E one though, it's a component test. I'd like to add an E2E test to cover this regression but Cypress doesn't really support hovering so it's a real hassle atm. Once we migrated to Playwright, it'll be a breeze instead. Hope this helps!

sfirke · 2025-02-12T17:38:51Z

Got it @hainenber - thanks for explaining that and thanks for the fix!

michael-s-molina · 2025-02-21T16:31:38Z

superset-frontend/src/pages/DashboardList/index.tsx

  'owners.id',
  'owners.first_name',
  'owners.last_name',
-  'owners',


@hainenber Can you confirm that the owners' fields, apart from id, first_name and last_name, are not being used? Same for changed_by's fields.

The attributes like owners.last_name are the one populating the owners field. For some reasons, you have to specify atributes for nested fields like owners and changed_by.

Maybe you misunderstood what I mean. Previously, we had owners being declared which means that ALL attributes of owners were accessible like full_name. Now that you excluded owners from the fetched columns, if there's some component accessing full_name, it will break. I'm ok with removing the whole owners object but we need to check which attributes are in fact being used so that the projection is correct.

I see. Then in that case, I'll only add the missing attributes and not to remove the nested field names to minimize any risks.

Re-added old nested fields. Issue is still fixed with less risks :D

…list

…ages Signed-off-by: hainenber <dotronghai96@gmail.com>

…olumn list Signed-off-by: hainenber <dotronghai96@gmail.com>

rusackas

LGTM! Thank you for addressing the comments/concerns!

#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

apache#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

* chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm` (apache#32780) * chore: Revert "chore: bump base image in Dockerfile with `ARG PY_VER=3.11.11-slim-bookworm`" (apache#32782) * fix(chart data): removing query from /chart/data payload when accessing as guest user (apache#30858) (cherry picked from commit dd39138) * fix: upgrade to 3.11.11-slim-bookworm to address critical vulnerabilities (apache#32240) (cherry picked from commit ad05732) * fix(model/helper): represent RLS filter clause in proper textual SQL string (apache#32406) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit ff0529c) * fix: Log table retention policy (apache#32572) (cherry picked from commit 89b6d7f) * fix(welcome): perf on distinct recent activities (apache#32608) (cherry picked from commit 832e028) * fix(log): Update recent_activity by event name (apache#32681) (cherry picked from commit 449f51a) * fix: Signature of Celery pruner jobs (apache#32699) (cherry picked from commit df06bdf) * fix(logging): missing path in event data (apache#32708) (cherry picked from commit cd5a943) * fix(fe/dashboard-list): display modifier info for `Last modified` data (apache#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5) * fix: make packages PEP 625 compliant (apache#32866) Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> (cherry picked from commit 6e02d19) * all cccs changes * fix: Downgrade to marshmallow<4 (apache#33216) * fix(log): store navigation path to get correct logging path (apache#32795) (cherry picked from commit 4a70065) * fix(pivot-table): Revert "fix(Pivot Table): Fix column width to respect currency config (apache#31414)" (apache#32968) (cherry picked from commit a36e636) * fix: improve error type on parse error (apache#33048) (cherry picked from commit ed0cd5e) * fix(plugin-chart-echarts): remove erroneous upper bound value (apache#32473) (cherry picked from commit 5766c36) * fix(pinot): revert join and subquery flags (apache#32382) (cherry picked from commit 822d72c) * fix: loading examples from raw.githubusercontent.com fails with 429 errors (apache#33354) (cherry picked from commit f045a73) * chore: creating 4.1.3rc1 change log and updating frontend json (cherry picked from commit 72cf9b6) * chore(🦾): bump python sqlglot 26.1.3 -> 26.11.1 (apache#32745) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 66c1a6a) * chore(🦾): bump python h11 0.14.0 -> 0.16.0 (apache#33339) Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 8252686) * docs: CVEs fixed on 4.1.2 (apache#33435) (cherry picked from commit 8a8fb49) * feat(api): Added uuid to list api calls (apache#32414) (cherry picked from commit 8decc9e) * fix(table-chart): time shift is not working (apache#33425) (cherry picked from commit dc44748) * fix(Sqllab): Autocomplete got stuck in UI when open it too fast (apache#33522) (cherry picked from commit b4e2406) * chore: update Dockerfile - Upgrade to 3.11.12 (apache#33612) (cherry picked from commit f0b6e87) * chore: updating 4.1.3rc2 change log * Select all Drag and Drop (#546) * add a select all button for the dnd select * remove cypress * chore(deps): bump cryptography from 43.0.3 to 44.0.1 (apache#32236) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fa09d81) * fix: Adds missing __init__ file to commands/logs (apache#33059) (cherry picked from commit c1159c5) * fix: Saved queries list break if one query can't be parsed (apache#34289) (cherry picked from commit 1e5a4e9) * chore: Adds 4.1.4RC1 data to CHANGELOG.md and UPDATING.md * tag bump for select all drag and drop * Fix package-lock.json * Add db migration, bump Docker image base * gevent for gunicorn * remove threads and make worker-connections configurable * Fix package-lock.json * tag bump for cccs build * Remove CCCS Dataset Explorer (#550) * tag bump for CCCS build --------- Signed-off-by: hainenber <dotronghai96@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gpchandran <poorana@gmail.com> Co-authored-by: Joe Li <joe@preset.io> Co-authored-by: Jack <41238731+fisjac@users.noreply.github.com> Co-authored-by: Đỗ Trọng Hải <41283691+hainenber@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: JUST.in DO IT <justin.park@airbnb.com> Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com> Co-authored-by: Andreas Motl <andreas.motl@crate.io> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Yuri <yuri.bogomolov@robinhood.com> Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: sha174n <105581038+sha174n@users.noreply.github.com> Co-authored-by: Paul Rhodes <withnale@users.noreply.github.com> Co-authored-by: Rafael Benitez <rebenitez1802@gmail.com> Co-authored-by: cccs-RyanK <102618419+cccs-RyanK@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: cyber-jessie <jessica.morris@cyber.gc.ca>

fix(fe/dashboard-list): display modifier info for Last modified data

f7bd9a6

Signed-off-by: hainenber <dotronghai96@gmail.com>

pull-request-size bot added the size/XS label Jan 30, 2025

chore: update DashboardList unit test with new fetch query params

add32de

Signed-off-by: hainenber <dotronghai96@gmail.com>

hainenber marked this pull request as ready for review January 30, 2025 14:12

dosubot bot added the listview:dashboards Related to the Dashboards' list label Jan 30, 2025

korbit-ai bot reviewed Jan 30, 2025

View reviewed changes

sadpandajoe approved these changes Jan 30, 2025

View reviewed changes

michael-s-molina self-requested a review February 12, 2025 17:44

michael-s-molina reviewed Feb 21, 2025

View reviewed changes

hainenber added 3 commits February 21, 2025 23:51

Merge branch 'master' into fix/missing-modifier-tooltip-in-dashboard-…

8f37ad2

…list

chore: re-add dashboard columns with nested field type to avoid break…

d7f4a17

…ages Signed-off-by: hainenber <dotronghai96@gmail.com>

fix(ci): refactor unit test to reflect changes in fetched dashboard c…

88fc9e0

…olumn list Signed-off-by: hainenber <dotronghai96@gmail.com>

rusackas approved these changes Feb 21, 2025

View reviewed changes

rusackas merged commit 88cf2d5 into apache:master Feb 21, 2025
48 checks passed

hainenber deleted the fix/missing-modifier-tooltip-in-dashboard-list branch February 22, 2025 00:44

michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 24, 2025

michael-s-molina pushed a commit that referenced this pull request Mar 5, 2025

fix(fe/dashboard-list): display modifier info for Last modified data (

7aa4cd4

#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 21, 2025

fix(fe/dashboard-list): display modifier info for Last modified data (

2046e0a

apache#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Mar 27, 2025

sadpandajoe pushed a commit that referenced this pull request Mar 27, 2025

fix(fe/dashboard-list): display modifier info for Last modified data (

ccfc07d

#32035) Signed-off-by: hainenber <dotronghai96@gmail.com> (cherry picked from commit 88cf2d5)

mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 5.0.0 Cherry-picked to 5.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 29, 2025

github-actions bot added the 🍒 4.1.4 label Aug 28, 2025

silveira-js mentioned this pull request Jan 7, 2026

Add MapLibre support to charts PortalTelemedicina/superset#4

Merged

9 tasks

This was referenced Jan 15, 2026

Point explicit service account to client PortalTelemedicina/superset#9

Merged

Fix margin parameters PortalTelemedicina/superset#10

Merged

silveira-js mentioned this pull request Jan 26, 2026

Adjust Styling Options PortalTelemedicina/superset#11

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(fe/dashboard-list): display modifier info for `Last modified` data#32035

fix(fe/dashboard-list): display modifier info for `Last modified` data#32035
rusackas merged 5 commits intoapache:masterfrom
hainenber:fix/missing-modifier-tooltip-in-dashboard-list

hainenber commented Jan 30, 2025 •

edited by sadpandajoe

Loading

Uh oh!

korbit-ai bot commented Jan 30, 2025

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

sfirke commented Feb 6, 2025

Uh oh!

hainenber commented Feb 11, 2025

Uh oh!

sfirke commented Feb 12, 2025

Uh oh!

michael-s-molina Feb 21, 2025 •

edited

Loading

Uh oh!

hainenber Feb 21, 2025

Uh oh!

michael-s-molina Feb 21, 2025

Uh oh!

hainenber Feb 21, 2025 •

edited

Loading

Uh oh!

hainenber Feb 21, 2025

Uh oh!

rusackas left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Naming	✅
Database Operations	✅
Documentation	✅
Logging	✅
Error Handling	✅
Systems and Environment	✅
Objects and Data Structures	✅
Readability and Maintainability	✅
Asynchronous Processing	✅
Design Patterns	✅
Third-Party Libraries	✅
Performance	✅
Security	✅
Functionality	✅

Conversation

hainenber commented Jan 30, 2025 • edited by sadpandajoe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

korbit-ai bot commented Jan 30, 2025

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

Uh oh!

sfirke commented Feb 6, 2025

Uh oh!

hainenber commented Feb 11, 2025

Uh oh!

sfirke commented Feb 12, 2025

Uh oh!

michael-s-molina Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hainenber Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

michael-s-molina Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

hainenber Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hainenber Feb 21, 2025

Choose a reason for hiding this comment

Uh oh!

rusackas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hainenber commented Jan 30, 2025 •

edited by sadpandajoe

Loading

korbit-ai bot left a comment •

edited

Loading

michael-s-molina Feb 21, 2025 •

edited

Loading

hainenber Feb 21, 2025 •

edited

Loading